Open
Conversation
Author
|
In order to define a clean interface we first need to clean some things. |
update imports; make unit tests pass; add travis config
If the runner needs the Stream value from the config, it should not get it from the reporter. It is better to keep a copy of the value in the runner itself to make the communication between runner and reporter only one-direction.
come-maiz
force-pushed
the
reporter_interface2
branch
from
0406dac to
2538f46
Compare
added 3 commits
May 26, 2016 18:59
The logger and the reporter should be configured independently. We can do many improvements in the logger, but for now this change preserves the public interfaces, keeps all the tests passing and lets us focus on improving the reporter first.
come-maiz
force-pushed
the
reporter_interface2
branch
from
2538f46 to
8b4d3d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.