Include obtained length to HasLen error message.#9
Include obtained length to HasLen error message.#9AlekSi wants to merge 1 commit intogo-check:v1from
Conversation
|
Any reason this can't be merged? |
|
Sorry for the very late review. I'm in the process of reorganizing my workflow to manage the firehose I've been dealing with. About the issue: Originally the error message should only be used when the checker is incorrectly dealt with, which is not the situation here. A non-matching HasLen is simply a failed check. That said, this is an interesting case. The usual technique of replacing the parameter value itself to better represent the check made is not ideal. We can either merge this and change the semantics of what that result means (perhaps doable), or we can improve the logging across the board for every slice or array, by mentioning its length. I'm tempted to go for the latter option. Please let me ponder on this just a bit longer. Will get back here in the next few days. |
|
Hit this issue again.
I'm all for it. |
|
Ping. |
Useful for long slices.