docs: settled design ADRs from aikit issues audit#101
Merged
Conversation
Adds the five architecture decision records that a grilling pass settled while reviewing the workspace for security, correctness, partial/dead functionality, and architectural smells: - 0012 sandbox is the trust boundary; serve fails closed on non-loopback - 0013 package install writes only within the target project - 0014 runs are cancellable; SIGTERM->SIGKILL over the process group - 0015 two agent registries: deploy-layout vs runnable Backend - 0016 serve emits canonical events; StreamFrame deleted, no back-compat Documentation only, no code changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
aroff
force-pushed
the
docs/issues-audit-remediation-2026-07-07
branch
from
3b3b9e2 to
093cd26
Compare
aroff
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the five design ADRs settled during a grilling pass over the workspace (security, correctness, partial/dead functionality, architecture). Documentation only — no code changes (5 files, +281 lines, 0 deletions).
ADRs
0012— the sandbox is the trust boundary foraikit serve; the network perimeter is the sole in-app control (fail closed on non-loopback without--api-key).0013— package install writes only within the target project (parse-time validation, abort on unsafe mapping, no-follow-symlinks).0014— runs are cancellable; termination escalates SIGTERM→SIGKILL over the process group.0015— two agent registries: deploy-layout vs runnableBackend.0016— serve emits canonical events;StreamFramedeleted, no back-compat shim.Notes for reviewers
specs/dir is gitignored by convention).🤖 Generated with Claude Code