Skip to content

Build prevent stale references#1

Open
willbonde wants to merge 2 commits into
gobii-ai:masterfrom
willbonde:build_prevent_stale_references
Open

Build prevent stale references#1
willbonde wants to merge 2 commits into
gobii-ai:masterfrom
willbonde:build_prevent_stale_references

Conversation

@willbonde
Copy link
Copy Markdown

  • Stale references were possible on macOS; change to prefer Unix-style libraries first
  • Fallback to unpack if table.unpack is not available

willbonde added 2 commits June 4, 2026 20:23
… to build. For example, my Silicon Mac found old x86 built libraries that were around for some reason
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces macOS-specific library search path preferences in CMake and improves Lua compatibility in the CLI prelude by providing a fallback for table.unpack. The review feedback suggests a safer check for CMAKE_FIND_FRAMEWORK in CMake to avoid overwriting variables defined in toolchain files or parent scopes.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread CMakeLists.txt
option(COMPUTER_CPP_ENABLE_WARNINGS "Enable strict compiler warnings for project targets" ON)
option(COMPUTER_CPP_ENABLE_SANITIZERS "Enable AddressSanitizer and UndefinedBehaviorSanitizer for project targets" OFF)

if(APPLE AND NOT DEFINED CACHE{CMAKE_FIND_FRAMEWORK})
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using NOT DEFINED CACHE{CMAKE_FIND_FRAMEWORK} only checks if the variable is defined in the CMake cache. If a toolchain file or a parent scope defines CMAKE_FIND_FRAMEWORK as a normal variable, this check will evaluate to true and overwrite that setting with LAST.

Using NOT DEFINED CMAKE_FIND_FRAMEWORK is safer and more robust as it respects both cache overrides and normal variable overrides (e.g., from toolchain files or parent scopes).

if(APPLE AND NOT DEFINED CMAKE_FIND_FRAMEWORK)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant