Skip to content

fix: Use hex string for blockNumber param in eth_getBlockReceipts#26

Open
lyfsn wants to merge 1 commit intogobitfly:mainfrom
lyfsn:pr
Open

fix: Use hex string for blockNumber param in eth_getBlockReceipts#26
lyfsn wants to merge 1 commit intogobitfly:mainfrom
lyfsn:pr

Conversation

@lyfsn
Copy link
Copy Markdown

@lyfsn lyfsn commented Mar 11, 2024

This eth method eth_getBlockReceipts needs a hex string value block number as the first parameter.

Before this code is fixed, this error will occur.

2024/03/11 10:17:41 error doing requestReceipts for slot 43215: io-error when fetching tx-receipts: invalid argument 0: json: cannot unmarshal number into Go value of type string

@ohko4711
Copy link
Copy Markdown

@danielCalbonero12345 @guybrush hi,

Although RECEIPTS_MODE_BATCH can be used to circumvent this issue, merging this PR can maintain consistency of our code repo and the upstream. Any questions are welcome for further discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants