fix: add recover fix panic on call to method #333
Open
zhaolunxiang123 wants to merge 2 commits intogodbus:masterfrom
Open
fix: add recover fix panic on call to method #333zhaolunxiang123 wants to merge 2 commits intogodbus:masterfrom
zhaolunxiang123 wants to merge 2 commits intogodbus:masterfrom
Conversation
add recover fix export method panic Log: add recover fix export method panic
Member
|
I have multiple issues with this:
|
add server err reply client Log: add server err reply client
Author
|
I can understand why not expose the recover return value to the D-Bus method caller, I'm adding a new server error return . it's from the application code, but export method too many,i can't fix it together . I refer to the GO standard library NET/HTTP in https://github.com/golang/go/blob/bd5595d7fa4eb3e234aabeac554f2ba8f2a95790/src/net/http/server.go#L1834 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add recover fix export method panic
Log: add recover fix export method panic