Legibility: team ring on every ship + hull name on the label - #16
Merged
Conversation
Owner: "I need to be able to tell what ship is what ship and what team they are on easily." Neither read was carried: - TEAM was conveyed by hull tint alone, and a tinted hull at speed in a brawl is not a friend/foe cue. Every unit now sits on a team-coloured ring (filled disc + rim) on the water plane, drawn always — not only when selected. The white selection ring layers on top, so "selected" stays distinct from "whose". Redrawn only when selection/team/radius change (the existing ring signature, now team-keyed), so it costs nothing per frame. - WHICH SHIP was never shown: the floating label carried only the captain's name. It now reads captain over hull, using ShipSpec .properName (Juggernaut, Leviathian, The Black Pearl...) — the per-hull name, since the generic class is shared by several hulls and cannot discriminate them. Missing properName degrades to the name alone. 1,249 tests green; lint clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner-reported: can't tell which ship is which or what team at a glance. Adds an always-on team-coloured ring under every unit (selection ring still layers on top) and puts the hull's
properNameunder the captain's name. 1,249 tests green.🤖 Generated with Claude Code