Skip to content

fix: tty passthrough#3

Merged
cmilesio merged 1 commit intomainfrom
cmiles/tty-fix
Jan 9, 2026
Merged

fix: tty passthrough#3
cmilesio merged 1 commit intomainfrom
cmiles/tty-fix

Conversation

@cmilesio
Copy link
Copy Markdown
Member

@cmilesio cmilesio commented Jan 9, 2026

This PR fixes an issue with default TTY passthrough. When stdout/stderr are real terminals and no line callbacks or combined output are enabled, execx no longer wraps them

Changes

  • New OnExecCmd hook to expose and mutate the underlying exec.Cmd before execution.
  • Documentation and examples updated for the new hook and TTY passthrough behavior.
  • Added terminal detection dependency (golang.org/x/term) and tests to keep coverage at 100%

@cmilesio cmilesio merged commit fd32601 into main Jan 9, 2026
1 check passed
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants