fix: Metal MSAA resolve store action for surface rendering#94
Merged
Conversation
Metal requires MTLStoreActionMultisampleResolve (or StoreAndMultisampleResolve) when a render pass color attachment has a resolve target. We were using MTLStoreActionStore, causing Metal to silently skip the MSAA resolve. The surface texture stayed uninitialized (purple screen on M3 Mac). Now setStoreAction is called AFTER checking ResolveTarget, and automatically upgraded to the correct resolve action when a resolve texture is present.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test plan