feat(natsapi): add health endpoint over NATS request-reply#269
Merged
Conversation
Add grlx.api.health NATS subject handler that returns farmer status, uptime, and NATS connection readiness. Reports 'degraded' when the NATS connection is down. - internal/natsapi/health.go: handler with HealthResponse type - internal/natsapi/subjects.go: MethodHealth constant and response type - internal/natsapi/router.go: register health handler in routes map - internal/natsapi/middleware.go: RBAC mapping (ActionView, public) - internal/api/client/health.go: CLI client Health() function - cmd/grlx/cmd/health.go: 'grlx health' CLI command (text + JSON) - Tests for both natsapi handler and client layers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
grlx.api.healthNATS subject handler to the farmer, providing health status, uptime, and NATS connection readiness over the NATS bus. This is part of the NATS-only migration — moving monitoring endpoints from HTTP to NATS request-reply.Changes
internal/natsapi/health.go: New handler returningHealthResponsewith status (ok/degraded), uptime, uptime_ms, and nats_ready fieldsinternal/natsapi/subjects.go:MethodHealthconstant andHealthCheckResponsetype aliasinternal/natsapi/router.go: Register health handler in the routes mapinternal/natsapi/middleware.go: RBAC mapping (ActionView) and public method (no auth token required, like version)internal/api/client/health.go: CLI clientHealth()function for NATS requestcmd/grlx/cmd/health.go:grlx healthCLI command with text and JSON output modesTesting
go test -race ./...)staticcheck)Context
Part of the NATS migration plan (architecture.md). The existing HTTP
/healthendpoint remains for unauthenticated monitoring, but this NATS endpoint gives authenticated users richer health data including NATS bus connectivity.