feat(natsapi): add jobs.delete endpoint for server-side job deletion#270
Merged
Conversation
Add grlx.api.jobs.delete NATS subject handler that deletes job log and metadata files from the farmer-side store. Previously, job deletion was only available in the local CLI-side store. Changes: - Store.DeleteJob() on farmer-side job store (searches all sprouts) - handleJobsDelete NATS handler with RBAC scope checks - client.DeleteJob() NATS client function - CLI 'grlx jobs delete' now defaults to farmer-side deletion with --local flag for local CLI-side store - 9 new tests (3 store, 4 handler, 2 client)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NATS Migration Part 2: Jobs Delete Endpoint
Part of the NATS-only farmer migration. Adds
grlx.api.jobs.deletesubject handler that enables server-side job deletion.Changes
Farmer-side store (
internal/jobs/store.go):Store.DeleteJob(jid)— searches all sprout directories, removes.jsonland.meta.jsonfilesNATS handler (
internal/natsapi/jobs.go):handleJobsDelete— validates JID, performs RBAC scope check against the job's sprout, then deletesActionJobAdmin(same asjobs.cancel)Client (
internal/api/client/jobs.go):DeleteJob(jid)— sendsjobs.deleterequest over NATSCLI (
cmd/grlx/cmd/jobs.go):grlx jobs delete <JID>now defaults to farmer-side deletion--localflag for local CLI-side store deletion (previous behavior)Tests
All existing tests continue to pass.