Skip to content

New option: run_once, and removed skip_waiting#7

Merged
stapelberg merged 1 commit intogokrazy:mainfrom
mpl:runonce
May 29, 2025
Merged

New option: run_once, and removed skip_waiting#7
stapelberg merged 1 commit intogokrazy:mainfrom
mpl:runonce

Conversation

@mpl
Copy link
Contributor

@mpl mpl commented Jan 15, 2025

  • new default behaviour: an update check is always attempted right from the start, regardless of check_frequency value.
  • run_once: controls whether we exit right after the initial update check.
  • skip_waiting: removed

Fixes #6

@mpl
Copy link
Contributor Author

mpl commented Jan 15, 2025

@damdo How do you work in the way of tests and CI? Are there going to be github actions running for this?
Disclaimer: I'm doing this PR on my mac, so I haven't tried building it or testing it (yet).

Copy link
Collaborator

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mpl the PR looks good to me, added two little nitpicks but nothing blocking.

@damdo
Copy link
Collaborator

damdo commented Jan 15, 2025

@damdo How do you work in the way of tests and CI? Are there going to be github actions running for this?
Disclaimer: I'm doing this PR on my mac, so I haven't tried building it or testing it (yet).

At the moment I use a very rough make target that I have checked in here: https://github.com/gokrazy/selfupdate/tree/e2e-test
The plan is to finish off gokrazy/tools#62 and then turn this into a go e2e test that we can run on GH actions.

@mpl
Copy link
Contributor Author

mpl commented Jan 16, 2025

@damdo do you prefer the --amend+push force flow (I'm used to it because of reasons), or do you want distinct commits on the PR, and we squash them all at merge time?

@damdo
Copy link
Collaborator

damdo commented Jan 16, 2025

Fine to amen + force push :) thanks for asking @mpl

@damdo
Copy link
Collaborator

damdo commented Jan 16, 2025

Thanks @mpl will do a manual test and add my review

- new default behaviour: an update check is always attempted right from
  the start, regardless of check_frequency value.
- run_once: controls whether we exit right after the initial update
  check.
- skip_waiting: removed

Fixes gokrazy#6
@damdo
Copy link
Collaborator

damdo commented May 25, 2025

@mpl Finally got around to test it, it was missing the declaration for runOnce.
I force pushed to your branch to quickly add it! Thanks!

@damdo
Copy link
Collaborator

damdo commented May 25, 2025

cc. @stapelberg for the merging, thanks!

@mpl
Copy link
Contributor Author

mpl commented May 26, 2025

@mpl Finally got around to test it, it was missing the declaration for runOnce. I force pushed to your branch to quickly add it! Thanks!

Whoops, thanks for the fix.

@stapelberg stapelberg merged commit 7a30c17 into gokrazy:main May 29, 2025
@mpl
Copy link
Contributor Author

mpl commented May 29, 2025

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support skipWaiting initially but keep periodically checking afterwards

3 participants