riscv64: add disassembly support and tests for zacas by newborn22 · Pull Request #17 · golang/arch

newborn22 · 2026-01-12T08:03:48Z

Add disassembly support and tests for Zacas extension on RISCV64.

gopherbot · 2026-01-12T08:12:21Z

This PR (HEAD: 9938bb6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/735520.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-01-12T08:21:18Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-01-12T10:21:36Z

Message from Weihong Qiu:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-27T14:09:59Z

Message from Joel Sing:

Patch Set 1: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-27T14:22:24Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-03-27T14:07:59Z","revision":"c1537c9c525283e27e5bdaa3f27ea5ee08d07b27"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-27T14:22:25Z

Message from Joel Sing:

Patch Set 1: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_13640>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-27T14:22:25Z

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-27T14:22:26Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-27T14:30:05Z

Message from Joel Sing:

Patch Set 1: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-27T14:30:06Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-03-27T14:22:23Z","revision":"c1537c9c525283e27e5bdaa3f27ea5ee08d07b27"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-27T14:41:28Z

Message from Joel Sing:

Patch Set 1: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_13640>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-27T14:41:29Z

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-28T14:13:32Z

Message from Mark Ryan:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-28T14:13:33Z

Message from Mark Ryan:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-05-13T06:07:21Z

Message from Mark Ryan:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-07-22T08:50:00Z

Message from Weihong Qiu:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-07-22T08:50:07Z

This PR (HEAD: b26b26e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/735520.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-08-02T18:40:44Z

Message from Mark Ryan:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-11T03:39:40Z

This PR (HEAD: d6398d2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/735520.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-08-11T06:03:44Z

Message from Weihong Qiu:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-26T07:29:51Z

Message from Mark Ryan:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-26T07:29:52Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-08-26T07:13:43Z","revision":"e7c129450c6a19d78dc8aa69eaf4ebb5a931b040"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-26T07:29:52Z

Message from Mark Ryan:

Patch Set 3: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_62943>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-26T07:29:53Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-26T07:29:53Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-26T07:49:55Z

Message from Mark Ryan:

Patch Set 3: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-26T08:08:43Z

Message from Meng Zhuo:

Patch Set 3: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-26T14:52:23Z

Message from Cherry Mui:

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-08-26T17:37:39Z

Message from David Chase:

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/735520.
After addressing review feedback, remember to publish your drafts!

Add disassembly support and tests for Zacas extension on RISCV64. Change-Id: Iea42ead99f5eba68f88c7a64e58cebba43d89a85 GitHub-Last-Rev: d6398d2 GitHub-Pull-Request: #17 Reviewed-on: https://go-review.googlesource.com/c/arch/+/735520 Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Mark Ryan <markdryan@meta.com> Reviewed-by: Meng Zhuo <mengzhuo1203@gmail.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

gopherbot · 2026-08-27T01:24:15Z

This PR is being closed because golang.org/cl/735520 has been merged.

riscv64: add disassembly support and tests for zacas

b26b26e

newborn22 force-pushed the zacas_disassembly branch from 9938bb6 to b26b26e Compare July 22, 2026 08:34

fix AMOCASQ rd register number to even to pass tests

d6398d2

gopherbot closed this Aug 27, 2026

Conversation

newborn22 commented Jan 12, 2026

Uh oh!

gopherbot commented Jan 12, 2026

Uh oh!

gopherbot commented Jan 12, 2026

Uh oh!

gopherbot commented Jan 12, 2026

Uh oh!

gopherbot commented Mar 27, 2026

Uh oh!

gopherbot commented Mar 27, 2026

Uh oh!

gopherbot commented Mar 27, 2026

Uh oh!

gopherbot commented Mar 27, 2026

Uh oh!

gopherbot commented Mar 27, 2026

Uh oh!

gopherbot commented Mar 27, 2026

Uh oh!

gopherbot commented Mar 27, 2026

Uh oh!

gopherbot commented Mar 27, 2026

Uh oh!

gopherbot commented Mar 27, 2026

Uh oh!

gopherbot commented Mar 28, 2026

Uh oh!

gopherbot commented Mar 28, 2026

Uh oh!

gopherbot commented May 13, 2026

Uh oh!

gopherbot commented Jul 22, 2026

Uh oh!

gopherbot commented Jul 22, 2026

Uh oh!

gopherbot commented Aug 2, 2026

Uh oh!

gopherbot commented Aug 11, 2026

Uh oh!

gopherbot commented Aug 11, 2026

Uh oh!

gopherbot commented Aug 26, 2026

Uh oh!

gopherbot commented Aug 26, 2026

Uh oh!

gopherbot commented Aug 26, 2026

Uh oh!

gopherbot commented Aug 26, 2026

Uh oh!

gopherbot commented Aug 26, 2026

Uh oh!

gopherbot commented Aug 26, 2026

Uh oh!

gopherbot commented Aug 26, 2026

Uh oh!

gopherbot commented Aug 26, 2026

Uh oh!

gopherbot commented Aug 26, 2026

Uh oh!

gopherbot commented Aug 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants