Skip to content

x86/x86asm: fix panic on truncated VEX/EVEX prefix - #25

Closed
nsavoire wants to merge 1 commit into
golang:masterfrom
nsavoire:x86asm-avx-truncated
Closed

nsavoire wants to merge 1 commit into
golang:masterfrom
nsavoire:x86asm-avx-truncated

Conversation

@nsavoire

@nsavoire nsavoire commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

decodeAVX guards every read from src except the opcode byte itself, so a
stream ending exactly at the end of a VEX or EVEX prefix indexes out of
range instead of reporting a truncated instruction:

c5 fc         panic: index out of range [2] with length 2
c4 e2 7d      panic: index out of range [3] with length 3
62 f1 7c 48   panic: index out of range [4] with length 4

Add the missing bounds check and extend TestDecodeDoesNotCrash with the
three prefix forms.

Fixes golang/go#81447.

@google-cla

google-cla Bot commented Sep 10, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

decodeAVX guards every read from src except the opcode byte itself, so
a stream ending exactly at the end of a VEX or EVEX prefix indexes out
of range instead of reporting a truncated instruction.

Add the missing bounds check and extend TestDecodeDoesNotCrash.

Fixes golang/go#81447.
@nsavoire
nsavoire force-pushed the x86asm-avx-truncated branch from 58b6ef6 to 2a9c2bc Compare September 10, 2026 12:43
@nsavoire
nsavoire marked this pull request as ready for review September 10, 2026 13:00
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 2a9c2bc) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/830644.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/830644.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/830644.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Nicolas Savoire:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/830644.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Keith Randall:

Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/830644.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-09-10T15:31:29Z","revision":"15e47b4e7a2cd46e7053c395bfe5a4480884ec3e"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/830644.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Keith Randall:

Patch Set 2: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/830644.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Keith Randall:

Patch Set 2: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_5200>)


Please don’t reply on this GitHub thread. Visit golang.org/cl/830644.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/830644.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/830644.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 11, 2026
decodeAVX guards every read from src except the opcode byte itself, so a
stream ending exactly at the end of a VEX or EVEX prefix indexes out of
range instead of reporting a truncated instruction:

	c5 fc         panic: index out of range [2] with length 2
	c4 e2 7d      panic: index out of range [3] with length 3
	62 f1 7c 48   panic: index out of range [4] with length 4

Add the missing bounds check and extend TestDecodeDoesNotCrash with the
three prefix forms.

Fixes golang/go#81447.

Change-Id: Id68526e432646ea95d2c1b84d715444ad2d4fb9a
GitHub-Last-Rev: 2a9c2bc
GitHub-Pull-Request: #25
Reviewed-on: https://go-review.googlesource.com/c/arch/+/830644
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
@gopherbot

Copy link
Copy Markdown
Contributor

This PR is being closed because golang.org/cl/830644 has been merged.

@gopherbot gopherbot closed this Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/arch/x86/x86asm: Decode panics on truncated VEX/EVEX prefix

2 participants