Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
decodeAVX guards every read from src except the opcode byte itself, so a stream ending exactly at the end of a VEX or EVEX prefix indexes out of range instead of reporting a truncated instruction. Add the missing bounds check and extend TestDecodeDoesNotCrash. Fixes golang/go#81447.
58b6ef6 to
2a9c2bc
Compare
|
This PR (HEAD: 2a9c2bc) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/830644. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/830644. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/830644. |
|
Message from Nicolas Savoire: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/830644. |
|
Message from Keith Randall: Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/830644. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-09-10T15:31:29Z","revision":"15e47b4e7a2cd46e7053c395bfe5a4480884ec3e"} Please don’t reply on this GitHub thread. Visit golang.org/cl/830644. |
|
Message from Keith Randall: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/830644. |
|
Message from Keith Randall: Patch Set 2: -Commit-Queue (Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_5200>) Please don’t reply on this GitHub thread. Visit golang.org/cl/830644. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/830644. |
|
Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/830644. |
decodeAVX guards every read from src except the opcode byte itself, so a stream ending exactly at the end of a VEX or EVEX prefix indexes out of range instead of reporting a truncated instruction: c5 fc panic: index out of range [2] with length 2 c4 e2 7d panic: index out of range [3] with length 3 62 f1 7c 48 panic: index out of range [4] with length 4 Add the missing bounds check and extend TestDecodeDoesNotCrash with the three prefix forms. Fixes golang/go#81447. Change-Id: Id68526e432646ea95d2c1b84d715444ad2d4fb9a GitHub-Last-Rev: 2a9c2bc GitHub-Pull-Request: #25 Reviewed-on: https://go-review.googlesource.com/c/arch/+/830644 Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@google.com>
|
This PR is being closed because golang.org/cl/830644 has been merged. |
decodeAVX guards every read from src except the opcode byte itself, so a
stream ending exactly at the end of a VEX or EVEX prefix indexes out of
range instead of reporting a truncated instruction:
Add the missing bounds check and extend TestDecodeDoesNotCrash with the
three prefix forms.
Fixes golang/go#81447.