webp: allow VP8L + VP8X(with alpha) by jespino · Pull Request #16 · golang/image

jespino · 2023-05-26T09:13:53Z

gopherbot · 2023-05-26T09:17:08Z

This PR (HEAD: ea485a6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/image/+/498535 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

AungThuSoe24 · 2024-07-15T19:49:11Z

TNrx3YHzhJYxHFo3eSLjEFpHZ3j9NBKbGR

AungThuSoe24 · 2024-07-15T19:49:21Z

TNrx3YHzhJYxHFo3eSLjEFpHZ3j9NBKbGR

AungThuSoe24 · 2024-07-15T19:49:33Z

webp/decode_test.go

@@ -179,6 +179,7 @@ func TestDecodeVP8L(t *testing.T) {
 		"gopher-doc.8bpp",


TNrx3YHzhJYxHFo3eSLjEFpHZ3j9NBKbGR

gopherbot · 2026-03-03T12:54:36Z

Message from Nigel Tao:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/498535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-03T12:54:45Z

This PR (HEAD: 304e63a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/image/+/498535.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-03-03T13:05:12Z

Message from Jesús Espino:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/498535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-03T13:05:13Z

Message from Gopher Robot:

Patch Set 2:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/498535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-04T09:49:23Z

Message from Nigel Tao:

Patch Set 2: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/498535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-04T09:49:24Z

Message from Nigel Tao:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/498535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-04T09:49:25Z

Message from Nigel Tao:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/498535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-04T10:36:54Z

Message from Nigel Tao:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/498535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-04T10:36:55Z

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/498535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-04T16:11:08Z

Message from Dmitri Shuralyov:

Patch Set 2: Auto-Submit+1 Code-Review+1 Commit-Queue+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/498535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-04T16:11:09Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-03-04T15:59:13Z","revision":"e75c9aa362b5a9a0c55d6e527bd08d055dfd77bb"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/498535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-04T16:11:10Z

Message from Dmitri Shuralyov:

Patch Set 2: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_35155>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/498535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-04T16:11:10Z

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/x_image-gotip-linux-arm64 has failed with summary (view all results):

go on master (commit 0b9bcbc) / image on master (change 498535)

To reproduce, try gomote repro 8688245998548158417.

Additional links for debugging:

test golang.org/x/image module output

Please don’t reply on this GitHub thread. Visit golang.org/cl/498535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-04T16:11:11Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/498535.
After addressing review feedback, remember to publish your drafts!

This fixes resizing and converting certain WebP images to PNG by inlining the decoder implementation and applying the following patch: golang/image#16 I chose this course of action since the bug was known upstream since 2023, but no action has been taken to review or accept the patch since then. In fact, the WebP decoder has historically seen fewer than one commit per year: https://github.com/golang/image/commits/master/webp/decode.go

gopherbot · 2026-03-05T21:12:24Z

Message from Nigel Tao:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/498535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-05T21:12:25Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-03-05T20:59:14Z","revision":"e75c9aa362b5a9a0c55d6e527bd08d055dfd77bb"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/498535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-05T21:12:25Z

Message from Nigel Tao:

Patch Set 2: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_5899>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/498535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-03-05T21:12:26Z

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/x_image-gotip-linux-arm64 has failed with summary (view all results):

go on master (commit 94a89c6) / image on master (change 498535)

To reproduce, try gomote repro 8688136525075077937.

Additional links for debugging:

test golang.org/x/image module output

Please don’t reply on this GitHub thread. Visit golang.org/cl/498535.
After addressing review feedback, remember to publish your drafts!

Allow to use VP8L+ICC in the same file without APLH chunk

ea485a6

AungThuSoe24 approved these changes Jul 15, 2024

View reviewed changes

cristaloleg mentioned this pull request Jul 23, 2025

x/image/webp: unable to decode image golang/go#60437

Open

Addressing PR review comments

304e63a

jespino changed the title ~~Allow to use VP8L+ICC in the same file without APLH chunk~~ webp: allow VP8L + VP8X(with alpha) Mar 3, 2026

		@@ -179,6 +179,7 @@ func TestDecodeVP8L(t *testing.T) {
		"gopher-doc.8bpp",

Conversation

jespino commented May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented May 26, 2023

Uh oh!

AungThuSoe24 commented Jul 15, 2024

Uh oh!

AungThuSoe24 commented Jul 15, 2024

Uh oh!

AungThuSoe24 Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

gopherbot commented Mar 3, 2026

Uh oh!

gopherbot commented Mar 3, 2026

Uh oh!

gopherbot commented Mar 3, 2026

Uh oh!

gopherbot commented Mar 3, 2026

Uh oh!

gopherbot commented Mar 4, 2026

Uh oh!

gopherbot commented Mar 4, 2026

Uh oh!

gopherbot commented Mar 4, 2026

Uh oh!

gopherbot commented Mar 4, 2026

Uh oh!

gopherbot commented Mar 4, 2026

Uh oh!

gopherbot commented Mar 4, 2026

Uh oh!

gopherbot commented Mar 4, 2026

Uh oh!

gopherbot commented Mar 4, 2026

Uh oh!

gopherbot commented Mar 4, 2026

Uh oh!

gopherbot commented Mar 4, 2026

Uh oh!

gopherbot commented Mar 5, 2026

Uh oh!

gopherbot commented Mar 5, 2026

Uh oh!

gopherbot commented Mar 5, 2026

Uh oh!

gopherbot commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jespino commented May 26, 2023 •

edited

Loading