Fix cacheit to cache Add(x,y) and Add(y,x) correctly.#1
Conversation
Before this commite the Add(x,y) and Add(y,x) yield different objects.
>>> Add(x,y) is Add(y,x)
False
It was because `cacheit` is called before `__new__` method.
In turn, the flatten method is calls inside the __new__.
In this pull request we inject the simple flatting procedure to the cacheit wrapper.
Notes:
Only one tests became to be a failure: "test_heurisch_symbolic_coeffs" in "test_risch"
It is marked as XFAIL now.
|
SymPy Bot Summary: All tests have passed. Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYlewQDA Interpreter: /usr/bin/python (2.7.2-final-0) Automatic review by SymPy Bot. |
|
SymPy Bot Summary: All tests have passed. Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYwdwQDA Interpreter: /usr/bin/python (2.7.2-final-0) Automatic review by SymPy Bot. |
|
SymPy Bot Summary: There were test failures. @goodok: Please fix the test failures. Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYtbIRDA Interpreter: /usr/bin/python (2.6.6-final-0) Automatic review by SymPy Bot. |
|
SymPy Bot Summary: All tests have passed. Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYl5MRDA Interpreter: /usr/bin/python (2.7.2-final-0) Automatic review by SymPy Bot. |
|
SymPy Bot Summary: All tests have passed. Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYrOQQDA Interpreter: /home/goodok/a/Python-2.5.6/python (2.5.6-final-0) Automatic review by SymPy Bot. |
|
SymPy Bot Summary: All tests have passed. Test results html report: http://reviews.sympy.org/report/agZzeW1weTNyDAsSBFRhc2sYr-QQDA Interpreter: /usr/bin/python (2.6.6-final-0) Automatic review by SymPy Bot. |
3532: Pow.is_real fix for base = -1
Make erfc and erfi functions available to MeijerG integration code
Make erfc and erfi functions tractable for Gruntz algorithm
More review on PR 2081: Merged in to PR sympy#2081
Before this pull request the
Add(x,y)andAdd(y,x)yield different objects.It was because the
cacheitis called before__new__method. In turn, theflattenmethod is calls inside the__new__.In this pull request we inject the simple
flattingprocedure to thecacheitwrapper.Also we allow to set the
@cacheitto the '_hashable_content..' function itself and without infinity recursion.also cache flatten arguments as synonyms in the cache.
Notes:
Only one tests became failure. It is
test_heurisch_symbolic_coeffsand marked as XFAIL.