Fix custom element WorkerService to match init() refactor#641
Open
zhaoyuheng200 wants to merge 2 commits into
Open
Fix custom element WorkerService to match init() refactor#641zhaoyuheng200 wants to merge 2 commits into
zhaoyuheng200 wants to merge 2 commits into
Conversation
The custom_element/worker_service.ts (used as a fileReplacement during the custom_element build) was not updated when 49aa6a8 refactored WorkerService to use a lazy init() method instead of constructor initialization. This breaks `ng build custom_element`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
custom_element/worker_service.ts(used viafileReplacementsinangular.jsonduring thecustom_elementbuild) was not updated when 49aa6a8 refactoredWorkerServiceto use a lazyinit()method instead of constructor initialization.ng build custom_elementto fail withTS2339: Property 'init' does not exist on type 'WorkerService', which blocks npm package builds.Test plan
ng build custom_element— should succeed without TS errorsnpm run build-npm— should produce the full npm package incustom_element_npm/dist/