Skip to content

Fix: Handle empty prompt arrays in make_seq2seq_fields (#483) #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ashutosh0x wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Handle empty prompt arrays in make_seq2seq_fields (#483) #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions gemma/gm/data/_functional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,18 @@ def make_seq2seq_fields(
sequence = np.concatenate([prompt, response])

# Create the loss mask.
if len(prompt) > 0:
prompt_mask = np.zeros((len(prompt) - 1,), dtype=np.bool_)
response_mask = np.ones((len(response),), dtype=np.bool_)
else:
# If no prompt, all targets come from response (shifted by 1)
prompt_mask = np.zeros((0,), dtype=np.bool_)
# Ensure non-negative shape if response is also empty or length 1
response_mask = np.ones((max(0, len(response) - 1),), dtype=np.bool_)

target_mask = np.concatenate([
np.zeros((len(prompt) - 1,), dtype=np.bool_),
np.ones((len(response),), dtype=np.bool_),
prompt_mask,
response_mask,
])

return Seq2SeqFields(
Expand Down