fix(data): add input validation for empty prompt/response in make_seq2seq_fields #493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds input validation to the make_seq2seq_fields function to handle empty prompt/response arrays gracefully.
Problem
When an empty prompt or response array is passed to make_seq2seq_fields, the function crashes with confusing numpy errors (negative array dimensions) instead of providing a clear error message.
Fixes #483
Solution
Added validation at the start of the function that:
esponse is empty and raises ValueError with clear message
Changes
File: gemma/gm/data/_functional.py
Testing