Refactor DPO example to parametrize dataset configuration #499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #498
This PR refactors
examples/dpo.pyto standardize it with other examples (likeseq2seq.pyandlora.py) and remove technical debt.Changes:
batch_sizeandmax_lengthvariables from_make_dataset.# TODO(epot): !!!!.get_config()to define these hyperparameters and pass them into the dataset builder.This improves the configurability of the script and cleans up the code style to match the rest of the repository.