feat(cli): update tailwind export to v4 format#33
Open
seonghobae wants to merge 1 commit intogoogle-labs-code:mainfrom
Open
feat(cli): update tailwind export to v4 format#33seonghobae wants to merge 1 commit intogoogle-labs-code:mainfrom
seonghobae wants to merge 1 commit intogoogle-labs-code:mainfrom
Conversation
This commit updates the Tailwind export functionality to support the new CSS-first format introduced in Tailwind v4. The no longer generates a JavaScript theme object. Instead, it produces a CSS string containing custom properties within a block, which is the standard configuration method for Tailwind v4. - The handler logic is updated to generate CSS variables. - The for the Tailwind emitter is updated to reflect the new string output type. - Unit tests for the handler are rewritten to assert the correct CSS string generation. - The main integration test in is updated to validate the new output format. - The field was also added to the root to unblock the build process in the clean worktree. Fixes google-labs-code#19 Related to google-labs-code#29
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
The implementation for the Tailwind v4 export format is complete and has been fully verified locally with passing builds and tests. The PR is currently blocked by the check, which requires manual intervention. The code itself is ready for review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Tailwind export functionality to support the new CSS-first format introduced in Tailwind v4. The handler now generates a CSS string with custom properties instead of a JavaScript theme object.
Fixes #19
Related to #29