feat(linter): add oklch color support#35
Open
seonghobae wants to merge 1 commit intogoogle-labs-code:mainfrom
Open
feat(linter): add oklch color support#35seonghobae wants to merge 1 commit intogoogle-labs-code:mainfrom
seonghobae wants to merge 1 commit intogoogle-labs-code:mainfrom
Conversation
This commit adds support for the OKLCH color model, allowing color values to be used in DESIGN.md files. - The function in the model spec is updated to recognize syntax. - The function in the model handler is updated to use the library to parse strings and convert them to the internal format, including the sRGB hex fallback and raw RGB values. - The type now includes an optional field to preserve the original value. - The library has been added as a dependency. - A TypeScript declaration file for is added to resolve type errors during the build. - Tests for color validation and parsing have been updated to include OKLCH cases. - The field was also added to the root to unblock the build process in the clean worktree. Fixes google-labs-code#27 Related to google-labs-code#29
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
The implementation for OKLCH color support is complete and has been fully verified locally with passing builds and tests. The PR is currently blocked by the check, which requires manual intervention. The code itself is ready for review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the OKLCH color model, allowing color values to be used in DESIGN.md files. The parsing logic is updated to handle this format, and the internal type is updated to preserve the original value.
Fixes #27
Related to #29