[ROCm] support hermetic sysroot and clean up hipcc wrapper#262
Merged
yuriivcs merged 8 commits intoMay 21, 2026
Conversation
alekstheod
force-pushed
the
rocm_clean_up_hipcc_wrapper
branch
from
2e96ca6 to
c6a5ba2
Compare
- Add LIBSTDCXX_FLAGS constant for static libstdc++ linking - Update ROCm toolchain to support both libc++ and libstdc++ static linking - This fixes hermetic builds where -nodefaultlibs requires explicit library linking - Resolves shutdown crashes caused by mixing hermetic headers with system runtime libs
alekstheod
force-pushed
the
rocm_clean_up_hipcc_wrapper
branch
3 times, most recently
from
3254949 to
5a7dde3
Compare
alekstheod
force-pushed
the
rocm_clean_up_hipcc_wrapper
branch
from
5a7dde3 to
4c90b44
Compare
yuriivcs
requested changes
May 21, 2026
| "//common:stdlib": "libstdc++", | ||
| "//common:static_libcxx": "True", | ||
| }, | ||
| ) |
Collaborator
There was a problem hiding this comment.
All config_setting in //common use names with prefix 'is_', try to use the same name convention in ROCM.
alekstheod
force-pushed
the
rocm_clean_up_hipcc_wrapper
branch
from
a8f5c04 to
b63c6d9
Compare
alekstheod
force-pushed
the
rocm_clean_up_hipcc_wrapper
branch
from
3bff893 to
c39d07a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building jax manylinux compatible requires hermetic sysroot support. This pr will drop the usage of local sysroot by the rocm toolchain. Followup PRs will be removing local sysroot as it is not required for the build anymore.