Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/sessions/in_memory_session_service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,10 @@ export class InMemorySessionService extends BaseSessionService {
session,
event,
}: AppendEventRequest): Promise<Event> {
if (event.partial) {
return event;
}

await super.appendEvent({session, event});
session.lastUpdateTime = event.timestamp;

Expand Down
25 changes: 25 additions & 0 deletions core/test/sessions/in_memory_session_service_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,31 @@ describe('InMemorySessionService', () => {
expect(retrievedSession?.lastUpdateTime).toBe(timestamp);
});

it('ignores partial events without updating the session', async () => {
const session = await service.createSession({
appName: 'app',
userId: 'user',
});
const initialUpdateTime = session.lastUpdateTime;
const partialEvent = createEvent({
partial: true,
timestamp: initialUpdateTime + 1000,
});

await service.appendEvent({session, event: partialEvent});

expect(session.events).toEqual([]);
expect(session.lastUpdateTime).toBe(initialUpdateTime);

const retrievedSession = await service.getSession({
appName: 'app',
userId: 'user',
sessionId: session.id,
});
expect(retrievedSession?.events).toEqual([]);
expect(retrievedSession?.lastUpdateTime).toBe(initialUpdateTime);
});

it('updates app state', async () => {
const appName = 'app';
const userId = 'user';
Expand Down
Loading