test: add unit tests for isCompactedEvent and createCompactedEvent#400
Closed
nuthalapativarun wants to merge 1 commit into
Closed
test: add unit tests for isCompactedEvent and createCompactedEvent#400nuthalapativarun wants to merge 1 commit into
nuthalapativarun wants to merge 1 commit into
Conversation
2 tasks
Contributor
Author
|
Closing in favour of the consolidated PR #413, as requested by @kalenkevich. All changes from this PR are included there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
Adds unit tests for
core/src/events/compacted_event.ts, which had no test coverage:isCompactedEvent— 4 cases: validCompactedEvent, plainEvent, event missing theisCompactedfield, and event whereisCompactedisfalsecreateCompactedEvent— 5 cases:isCompactedflag is set totrue,startTime/endTime/compactedContentare carried through, baseEventdefaults are merged (id, invocationId, actions),authorandcontentparams are respected, and the created event satisfies theisCompactedEventtype guardTesting Plan
Unit Tests:
Manual End-to-End (E2E) Tests:
Pure unit tests with no dependencies on external services.
Checklist