Fix: Fix state mutation bad practice in content_processor_utils.ts#430
Open
AmaadMartin wants to merge 2 commits into
Open
Fix: Fix state mutation bad practice in content_processor_utils.ts#430AmaadMartin wants to merge 2 commits into
AmaadMartin wants to merge 2 commits into
Conversation
ffa41d6 to
897bbbd
Compare
9e5758d to
cc38a19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
Closes: N/A
Related: N/A
2. Or, if no issue exists, describe the change:
Problem: The
rearrangeEventsForLatestFunctionResponseandmergeFunctionResponseEventsfunctions incontent_processor_utils.tshad state mutation issues where the original events list and event content were mutated/modified directly, causing unexpected side effects.Solution: Cloned the content of the first event during merge, and cloned media parts in convertForeignEvent fallback block to avoid state mutation by reference. Avoided using mutable state variables in
rearrangeEventsForLatestFunctionResponseand cleaned up matching variables. Added comprehensive unit tests covering all edges and state mutation checks to guarantee correctness.Testing Plan
Please describe the tests that you ran to verify your changes. This is required for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed npm test results.
Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any necessary setup or configuration. Please provide logs or screenshots to help reviewers better understand the fix.
To manually verify:
Checklist
Additional context
Add any other context or screenshots about the feature request here.