Fix: remove hardcoded us-central1 for RAG engine region#1175
Open
oxlipefe wants to merge 1 commit intogoogle:mainfrom
Open
Fix: remove hardcoded us-central1 for RAG engine region#1175oxlipefe wants to merge 1 commit intogoogle:mainfrom
oxlipefe wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the hardcoded
us-central1location in the RAG example and instead reads the region from theGOOGLE_CLOUD_LOCATIONenvironment variable.Motivation
For new Google Cloud projects, RAG Engine is restricted in
us-central1,us-east1, andus-east4. The current example fails with anINVALID_ARGUMENTerror in those regions.Using the environment variable improves flexibility and prevents unnecessary errors.
Changes
us-central1