fix: use userId from eval result to prevent session 404#424
Draft
brucearctor wants to merge 1 commit intogoogle:mainfrom
Draft
fix: use userId from eval result to prevent session 404#424brucearctor wants to merge 1 commit intogoogle:mainfrom
brucearctor wants to merge 1 commit intogoogle:mainfrom
Conversation
The eval tab was using the component-level userId input (defaulting to 'user') when fetching sessions for eval results. If the eval runner created sessions with a different user_id, the session lookup would 404. Now uses the userId returned in the eval result response, falling back to the component userId if not present. Also adds userId to the EvaluationResult interface and captures it in the history result mapping. Ref: google/adk-python#5423
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the session 404 error reported in google/adk-python#5423 (Issue 1).
Problem
The eval tab component used the component-level
userIdinput (which defaults to"user") when fetching sessions for eval results viagetSession(). If the eval runner created sessions with a differentuser_id(e.g., from the eval set'ssession_input.user_id), the session lookup would 404.Fix
userIdfield to theEvaluationResultinterfacegetSession()now usesevalCaseResult.userId(from the API response) instead ofthis.userId(), with a fallback to the component input if not presentuserIdin the history result mapping for consistencyCompanion PR
Server-side default alignment: google/adk-python#5425
Related