Skip to content

IDA: Fix ida(64) executable detection. #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alula wants to merge 1 commit into
base: main
Choose a base branch
from
Open

IDA: Fix ida(64) executable detection. #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 47 additions & 15 deletions util/idb_export.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,43 @@ constexpr const char* OptionBool(bool value) {
return value ? "TRUE" : "FALSE";
}

absl::flat_hash_map<std::string, std::string> ida_exe_path_cache;
absl::Mutex ida_exe_path_cache_mutex;
std::string GetIdaExePath(const std::string& ida_dir, bool is_64bit) {
absl::MutexLock lock(&ida_exe_path_cache_mutex);

const std::string key =
absl::StrCat(ida_dir, is_64bit ? ":64" : ":32");
auto it = ida_exe_path_cache.find(key);
if (it != ida_exe_path_cache.end()) {
return it->second;
}

#ifdef _WIN32
const auto ida64_exe_path = JoinPath(ida_dir, "ida64.exe");
const auto ida_exe_path = JoinPath(ida_dir, "ida.exe");
#else
const auto ida64_exe_path = JoinPath(ida_dir, "ida64");
const auto ida_exe_path = JoinPath(ida_dir, "ida");
#endif

const std::string main_ida_exe_path =
is_64bit ? ida64_exe_path : ida_exe_path;
if (FileExists(ida_exe_path)) {
ida_exe_path_cache[key] = main_ida_exe_path;
return main_ida_exe_path;
}

if (FileExists(ida_exe_path)) {
ida_exe_path_cache[key] = ida_exe_path;
return ida_exe_path;
}

// Cache the negative result as well.
ida_exe_path_cache[key] = "";
return "";
}

} // namespace

void IdbExporter::AddDatabase(std::string path) {
Expand All @@ -58,22 +95,17 @@ absl::Status ExportDatabase(const std::string& idb_path,
return absl::NotFoundError(absl::StrCat("File not found: " + idb_path));
}

#if IDA_SDK_VERSION < 900
const bool is_64bit = absl::EndsWithIgnoreCase(idb_path, kIdbExtension64);
#ifdef _WIN32
const std::string ida_exe = is_64bit ? "ida64.exe" : "ida.exe";
#else
const std::string ida_exe = is_64bit ? "ida64" : "ida";
#endif
#else
#ifdef _WIN32
const std::string ida_exe = "ida.exe";
#else
const std::string ida_exe = "ida";
#endif
#endif
const auto ida_exe_path =
GetIdaExePath(options.ida_dir, absl::EqualsIgnoreCase(
GetFileExtension(idb_path),
kIdbExtension64));
if (ida_exe_path.empty()) {
return absl::NotFoundError(absl::StrCat(
"Cannot find IDA executable in: ", options.ida_dir));
}

std::vector<std::string> args;
args.push_back(JoinPath(options.ida_dir, ida_exe));
args.push_back(ida_exe_path);
args.push_back("-A");
args.push_back("-OBinExportAutoAction:BinExportBinary");
args.push_back(absl::StrCat(
Expand Down