Skip to content

Allow missing DlInfo. #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jan 16, 2026
+6 −4
Merged

Allow missing DlInfo. #1959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions centipede/sancov_object_array.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ void SanCovObjectArray::PCInfoInit(const PCInfo *absl_nullable pcs_beg,
sancov_object.pcs_beg = pcs_beg;
sancov_object.pcs_end = pcs_end;
sancov_object.dl_info = GetDlInfo(pcs_beg->pc);
RunnerCheck(sancov_object.dl_info.IsSet(), "failed to compute dl_info");
if (sancov_object.pc_guard_start != nullptr) {
// Set is_function_entry for all the guards.
for (size_t i = 0, n = pcs_end - pcs_beg; i < n; ++i) {
Expand Down Expand Up @@ -132,8 +131,10 @@ std::vector<PCInfo> SanCovObjectArray::CreatePCTable() const {
const auto &object = objects_[i];
for (const auto *ptr = object.pcs_beg; ptr != object.pcs_end; ++ptr) {
auto pc_info = *ptr;
// Convert into the link-time address
pc_info.pc -= object.dl_info.link_offset;
if (object.dl_info.IsSet()) {
// Convert into the link-time address
pc_info.pc -= object.dl_info.link_offset;
}
result.push_back(pc_info);
}
}
Expand Down Expand Up @@ -162,7 +163,8 @@ DsoTable SanCovObjectArray::CreateDsoTable() const {
for (size_t i = 0; i < size(); ++i) {
const auto &object = objects_[i];
size_t num_instrumented_pcs = object.pcs_end - object.pcs_beg;
result.push_back({object.dl_info.path, num_instrumented_pcs});
result.push_back({object.dl_info.IsSet() ? object.dl_info.path : "UNKNOWN",
num_instrumented_pcs});
}
return result;
}
Expand Down
Loading