vulkan: Map R4G4B4A4_UNORM to VK_FORMAT_R4G4B4A4_UNORM_PACK16#161
Merged
Conversation
ToVkFormat had no mapping for GfxstreamFormat::R4G4B4A4_UNORM, so creating an RGBA4 color buffer failed with "Unsupported internal format" on every driver except under the lavapipe ICD override, where the format is substituted with B4G4R4A4 before the lookup. The format is already listed in the image support queries and the linear format plane layouts; only the enum mapping (and its inverse) was missing. With the mapping in place, RoundTripsRgba4ColorBufferContents exercises the native RGBA4 path instead of skipping. Test: bazel test //host/vulkan:vk_common_operations_tests Change-Id: I4b4e9fb042b8aa62cef851c8cb5a5eb270c91b9a
Contributor
Author
|
Hi @jmacnak , PTAL. Thanks. |
jmacnak
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToVkFormat had no mapping for GfxstreamFormat::R4G4B4A4_UNORM, so creating an RGBA4 color buffer failed with "Unsupported internal format" on every driver except under the lavapipe ICD override, where the format is substituted with B4G4R4A4 before the lookup. The format is already listed in the image support queries and the linear format plane layouts; only the enum mapping (and its inverse) was missing.
With the mapping in place, RoundTripsRgba4ColorBufferContents exercises the native RGBA4 path instead of skipping.
Test: bazel test //host/vulkan:vk_common_operations_tests
Change-Id: I4b4e9fb042b8aa62cef851c8cb5a5eb270c91b9a