-
Notifications
You must be signed in to change notification settings - Fork 61
getSupportedMimeTypes() API #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d25d121
init
davidjiagoogle 50795d4
kdocs & spotless
davidjiagoogle 01a511a
post init call
davidjiagoogle d0de050
move to SystemConstraints & add tests
davidjiagoogle aee4c2f
Merge branch 'main' into david/iscamerasupported
davidjiagoogle 2d384dd
add test runner
davidjiagoogle e1039a9
Update CameraXCameraSystem.kt
davidjiagoogle fc6931f
Merge branch 'main' into david/iscamerasupported
davidjiagoogle efb93b3
Update Constraints.kt
davidjiagoogle c280e67
Update Constraints.kt
davidjiagoogle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
150 changes: 150 additions & 0 deletions
150
data/settings/src/test/java/com/google/jetpackcamera/settings/ConstraintsTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,150 @@ | ||
| /* | ||
| * Copyright (C) 2026 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.google.jetpackcamera.settings | ||
|
|
||
| import com.google.common.truth.Truth.assertThat | ||
| import com.google.jetpackcamera.model.DynamicRange | ||
| import com.google.jetpackcamera.model.ImageOutputFormat | ||
| import com.google.jetpackcamera.model.LensFacing | ||
| import com.google.jetpackcamera.model.StreamConfig | ||
| import com.google.jetpackcamera.settings.model.CameraConstraints | ||
| import com.google.jetpackcamera.settings.model.CameraSystemConstraints | ||
| import com.google.jetpackcamera.settings.model.getSupportedMimeTypes | ||
| import org.junit.Test | ||
| import org.junit.runner.RunWith | ||
| import org.junit.runners.JUnit4 | ||
|
|
||
| @RunWith(JUnit4::class) | ||
| class ConstraintsTest { | ||
|
|
||
| @Test | ||
| fun getSupportedMimeTypes_returnsEmptyMap_whenNoLensesAvailable() { | ||
| val constraints = CameraSystemConstraints(availableLenses = emptyList()) | ||
| val result = constraints.getSupportedMimeTypes() | ||
| assertThat(result).isEmpty() | ||
| } | ||
|
|
||
| @Test | ||
| fun getSupportedMimeTypes_returnsJpegAndMp4_forTypicalLens() { | ||
| val constraints = CameraSystemConstraints( | ||
| availableLenses = listOf(LensFacing.BACK), | ||
| perLensConstraints = mapOf( | ||
| LensFacing.BACK to createConstraints( | ||
| imageFormats = setOf(ImageOutputFormat.JPEG), | ||
| dynamicRanges = setOf(DynamicRange.SDR) | ||
| ) | ||
| ) | ||
| ) | ||
|
|
||
| val result = constraints.getSupportedMimeTypes() | ||
|
|
||
| assertThat(result[LensFacing.BACK]).containsExactly("image/jpeg", "video/mp4") | ||
| } | ||
|
|
||
| @Test | ||
| fun getSupportedMimeTypes_onlyReturnsJpeg_whenNoDynamicRangesSupported() { | ||
| val constraints = CameraSystemConstraints( | ||
| availableLenses = listOf(LensFacing.BACK), | ||
| perLensConstraints = mapOf( | ||
| LensFacing.BACK to createConstraints( | ||
| imageFormats = setOf(ImageOutputFormat.JPEG), | ||
| dynamicRanges = emptySet() | ||
| ) | ||
| ) | ||
| ) | ||
|
|
||
| val result = constraints.getSupportedMimeTypes() | ||
|
|
||
| assertThat(result[LensFacing.BACK]).containsExactly("image/jpeg") | ||
| } | ||
|
|
||
| @Test | ||
| fun getSupportedMimeTypes_onlyReturnsMp4_whenJpegNotSupported() { | ||
| val constraints = CameraSystemConstraints( | ||
| availableLenses = listOf(LensFacing.BACK), | ||
| perLensConstraints = mapOf( | ||
| LensFacing.BACK to createConstraints( | ||
| imageFormats = emptySet(), | ||
| dynamicRanges = setOf(DynamicRange.SDR) | ||
| ) | ||
| ) | ||
| ) | ||
|
|
||
| val result = constraints.getSupportedMimeTypes() | ||
|
|
||
| assertThat(result[LensFacing.BACK]).containsExactly("video/mp4") | ||
| } | ||
|
|
||
| @Test | ||
| fun getSupportedMimeTypes_returnsEmptySet_whenNeitherSupported() { | ||
| val constraints = CameraSystemConstraints( | ||
| availableLenses = listOf(LensFacing.BACK), | ||
| perLensConstraints = mapOf( | ||
| LensFacing.BACK to createConstraints( | ||
| imageFormats = emptySet(), | ||
| dynamicRanges = emptySet() | ||
| ) | ||
| ) | ||
| ) | ||
|
|
||
| val result = constraints.getSupportedMimeTypes() | ||
|
|
||
| assertThat(result[LensFacing.BACK]).isEmpty() | ||
| } | ||
|
|
||
| @Test | ||
| fun getSupportedMimeTypes_handlesMultipleLensesSeparately() { | ||
| val constraints = CameraSystemConstraints( | ||
| availableLenses = listOf(LensFacing.BACK, LensFacing.FRONT), | ||
| perLensConstraints = mapOf( | ||
| LensFacing.BACK to createConstraints( | ||
| imageFormats = setOf(ImageOutputFormat.JPEG), | ||
| dynamicRanges = setOf(DynamicRange.SDR) | ||
| ), | ||
| LensFacing.FRONT to createConstraints( | ||
| imageFormats = setOf(ImageOutputFormat.JPEG), | ||
| dynamicRanges = emptySet() | ||
| ) | ||
| ) | ||
| ) | ||
|
|
||
| val result = constraints.getSupportedMimeTypes() | ||
|
|
||
| assertThat(result[LensFacing.BACK]).containsExactly("image/jpeg", "video/mp4") | ||
| assertThat(result[LensFacing.FRONT]).containsExactly("image/jpeg") | ||
| } | ||
|
|
||
| /** | ||
| * Helper to create CameraConstraints with specific formats/ranges for testing. | ||
| */ | ||
| private fun createConstraints( | ||
| imageFormats: Set<ImageOutputFormat>, | ||
| dynamicRanges: Set<DynamicRange> | ||
| ): CameraConstraints { | ||
| return CameraConstraints( | ||
| supportedStabilizationModes = emptySet(), | ||
| supportedFixedFrameRates = emptySet(), | ||
| supportedDynamicRanges = dynamicRanges, | ||
| supportedVideoQualitiesMap = emptyMap(), | ||
| supportedImageFormatsMap = mapOf(StreamConfig.SINGLE_STREAM to imageFormats), | ||
| supportedIlluminants = emptySet(), | ||
| supportedFlashModes = emptySet(), | ||
| supportedZoomRange = null, | ||
| unsupportedStabilizationFpsMap = emptyMap(), | ||
| supportedTestPatterns = emptySet() | ||
| ) | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.