Skip to content

Fix incorrect missing-item handling in ExecutionTrace.remove #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ibarraz5 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix incorrect missing-item handling in ExecutionTrace.remove #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4b69f6
Fix typo in 'development' in README.md
ibarraz5 Nov 17, 2025
f9c0ad7
fix: handle missing items correctly in ExecutionTrace.remove
ibarraz5 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Langfun is *simple and elegant*:
* An intuitive programming model, graspable in 5 minutes;
* Plug-and-play into any Python codebase, making an immediate difference;
* Comprehensive LLMs under a unified API: Gemini, GPT, Claude, Llama3, and more.
* Designed for agile developement: offering intellisense, easy debugging, with minimal overhead;
* Designed for agile development: offering intellisense, easy debugging, with minimal overhead;

## Hello, Langfun

Expand Down
9 changes: 5 additions & 4 deletions langfun/core/agentic/action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,10 +780,11 @@ def append(self, item: TracedItem) -> None:

def remove(self, item: TracedItem) -> None:
"""Removes an item from the sequence."""
index = self.items.index(item)
if index == -1:
raise ValueError(f'Item not found in execution trace: {item!r}')

try:
index = self.items.index(item)
except ValueError as exc:
raise ValueError(f'Item not found in execution trace: {item!r}') from exc

with pg.notify_on_change(False):
self.items.pop(index)

Expand Down