Fix: Add dotenv.load_dotenv() to tools.py #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
rahul188
force-pushed
the
fix/load-dotenv-in-tools
branch
2 times, most recently
from
435ccfa to
9fced19
Compare
…Y is available Moved dotenv.load_dotenv() and API key retrieval inside get_maps_mcp_toolset() function. This ensures the .env file is loaded before reading MAPS_API_KEY, fixing the issue where it would default to 'no_api_found'. This follows Python best practices by: - Keeping all imports at the top of the file - Using lazy evaluation for environment variables - Avoiding code execution at module import time
rahul188
force-pushed
the
fix/load-dotenv-in-tools
branch
from
9fced19 to
27f3e4d
Compare
Collaborator
|
Thanks Rahul, tested and approved. |
askmeegs
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11
Problem:
The
tools.pymodule was reading theMAPS_API_KEYenvironment variable before the.envfile was loaded, causing it to always default to'no_api_found'.Root Cause:
MAPS_API_KEYwas being read at module import time, before any code calleddotenv.load_dotenv().Solution:
Moved
dotenv.load_dotenv()and API key retrieval inside theget_maps_mcp_toolset()function. This ensures the .env file is loaded before reading the environment variable.Why this approach:
Testing:
Verified with dummy .env file that
MAPS_API_KEYnow correctly loads from the environment.Files Changed:
examples/launchmybakery/adk_agent/mcp_bakery_app/tools.py