-
Notifications
You must be signed in to change notification settings - Fork 444
Allow build environments where only VS2026 is installed #1407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you for the pull request, but I have a feeling that we need a bit more preparations to officially support Visual Studio 2026. I actually considered supporting Visual Studio 2026, but decided to postpone it at that time for the following reasons:
I don't know why you didn't get the errors above, but if it works for you can maintain your patch locally for now? |
I created a discussion thread for people to keep posting there findings towards using Visual Studio 2026 to build package for Mozc. Feel free to use it. |
|
I got a build error in one of the 3 commands, but different error message that shows the hard-code of VS 2022 path and suggests the execution of It may be better to add a new option like |
|
|
If I suspect that the situation you were hitting is similar to the following case, when the result of |
|
The error message was changed: I do not have sufficient knowledge on Bazel to fix this error by myself unfortunately. |
Description
A clear and concise description of this pull request.
It can be burden for storage to preserve both VS 2022 and 2026.
It is better to allow developers to try building Mozc on newer Visual Studio than 2022.
If there are blockers, developers should report them here.
Issue IDs
Issue and/or discussion IDs related to this pull request.
Fix regression by #1402
Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).
cd srcpython build_tools/update_deps.py && python build_tools/build_qt.py --release --confirm_licenseAdditional context
Add any other context about the pull request here.
Which Python formatter do you prefer?