[apache-poi] Add targeted FormulaParser fuzzer#14977
Open
vishalcoc44 wants to merge 2 commits intogoogle:masterfrom
Open
[apache-poi] Add targeted FormulaParser fuzzer#14977vishalcoc44 wants to merge 2 commits intogoogle:masterfrom
vishalcoc44 wants to merge 2 commits intogoogle:masterfrom
Conversation
|
vishalcoc44 is a new contributor to projects/apache-poi. The PR must be approved by known contributors before it can be merged. The past contributors are: centic9, centic9-dt, arthurscchan, aschaich |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a targeted fuzzer for the Apache POI
FormulaParser(org.apache.poi.ss.formula.FormulaParser).Logic Crash Identified
During local stress-testing of this fuzzer, I identified a logic flaw in the "Structured Reference" state machine.
[[or[[[]) cause the parser to increment its internal pointer beyond the string bounds.java.lang.RuntimeException: Parsed past the end of the formula, pos: 3, length: 2, formula: [[Implementation Details
FormulaParser.parse()(High complexity, high value).POIFuzzer.adjustLimits()and broad exception handling to ensure long-running stability..dictfile containing Excel formula tokens (Structured References, standard functions) to guide the fuzzer into deeper logic branches.Verification Plan (For Maintainers)
To verify the crash found by this fuzzer:
FormulaParserFuzzer.[[crash.FormulaParser.parse("[[", workbook, FormulaType.CELL, -1).