Partial implementation of supporting http routing annotations in generated grpc code#1061
Draft
devoncarew wants to merge 2 commits intogoogle:masterfrom
Draft
Partial implementation of supporting http routing annotations in generated grpc code#1061devoncarew wants to merge 2 commits intogoogle:masterfrom
devoncarew wants to merge 2 commits intogoogle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial implementation of support http routing annotations in generated grpc code. The main remaining thing is to augment package:grpc so that we can inspect the first request on a stream and use that to inform the http headers to use on that call. Unary requests are supported by this PR.
See #1018 for full context.
protos/google/api/annotations.proto)For an example of the generated output from this PR see dart-lang/labs#285.
cc @mosuem