python: validate offsets to prevent OOB reads in _re2 #590
+69
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a memory-safety issue in the RE2 Python extension (
_re2)where user-controlled offsets could cause out-of-bounds reads and crash
the hosting process.
The helper functions that convert between character offsets and byte
offsets performed unchecked pointer arithmetic
(
text.data() + pos/text.data() + endpos) and then dereferenced theresult. If a caller supplied a negative or out-of-range offset, the code
could read outside the buffer bounds, resulting in a native crash.
Changes
itemsize == 1)pos,endpos, andlenranges before pointer arithmeticperforming unsafe memory access
Impact
Testing
poslenpos > endposendposout of range