This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Conversation
Hi @dennybritz, I had to make these proposed changes to make the ScheduledOutputSampling work. I was getting `Can't convert bool to float 32` error before adding `maybe_concatenate_auxiliary_inputs(outputs).cell_output` to line 420. I also got `InvalidArgumentError: TensorArray dtype is int32 but Op is trying to write dtype bool.` before making the changes to line 387, 388 and the casting in 420. Please advice if the changes are valid.
Adding changes from @graehls pull request 'cause tests were failing.
Adding changes from @graehls pull request 'cause tests were failing.
Adding changes from @graehl's pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @dennybritz , I had to make these proposed changes to make the ScheduledOutputSampling work. I was getting
Can't convert bool to float 32error before addingmaybe_concatenate_auxiliary_inputs(outputs).cell_outputto line 420. I also gotInvalidArgumentError: TensorArray dtype is int32 but Op is trying to write dtype bool.before making the changes to line 387, 388 and the casting in 420. Please advice if the changes are valid.