This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Code optimizations as per pylint suggestions#247
Open
Demfier wants to merge 1 commit intogoogle:masterfrom
Open
Code optimizations as per pylint suggestions#247Demfier wants to merge 1 commit intogoogle:masterfrom
Demfier wants to merge 1 commit intogoogle:masterfrom
Conversation
Author
|
@dennybritz Please review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added some code optimizations as per pylint suggestions.
There are a 3
(useless-self-deligations)and 1 code-duplication instance (seq2seq.encoders.conv_encoder:66&seq2seq.encoders.pooling_encoder:120) left.I didn't change the
getargspec()method inseq2seq/training/utils.pyas it's not backward compatible with python2.Previous code rating: 9.94/10
Current code rating: 9.98/10
This has been addressed here #237
Ping @dennybritz .