Fix: Compilation issue causing incompatibility on Android via ADB or Termux - #166
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
antiagainst
approved these changes
Sep 2, 2025
antiagainst
left a comment
antiagainst
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. @JunePrimavera would you mind click through the CLA so I can merge? Thanks.
Contributor
Author
|
I have gone through the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, this is a pretty minor patch to ensure the project can correctly get compiled on Android systems (Through a terminal emulator such as Termux or ADB).
It simply changes a check in the
build.rsbuildscript to check for either Linux or Android, instead of just Linux. So many ARM devices (Often with their own unique GPUs) use Android and don't support regular Linux distributions, so this is useful for testing on these systems.