Repository navigation
Support aarch32 without requiring codegen flags - #33
Merged
Merged
Conversation
For aarch32, using the 'hvc' and 'smc' instructions in 'asm!()' requires '-C target-feature=+virtualization,+trustzone'. By replacing 'hvc #0' and 'smc #0' with their corresponding opcodes (one instance each), we can support aarch32 without requiring these codegen flags. Signed-off-by: Nick Spinale <nick@nickspinale.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
qwandor
approved these changes
May 28, 2026
nspin
added a commit
to nspin/rust-sel4
that referenced
this pull request
Jul 17, 2026
Now that google/smccc#33 has landed
nspin
added a commit
to nspin/rust-sel4
that referenced
this pull request
Jul 17, 2026
Now that google/smccc#33 has landed
nspin
added a commit
to nspin/rust-sel4
that referenced
this pull request
Jul 17, 2026
Now that google/smccc#33 has landed
nspin
added a commit
to nspin/rust-sel4
that referenced
this pull request
Jul 17, 2026
Now that google/smccc#33 has landed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #10, for aarch32, using the
hvcandsmcinstructions inasm!()requires-C target-feature=+virtualization,+trustzone. By replacinghvc #0andsmc #0with their corresponding opcodes (one instance each), we can support aarch32 without requiring these codegen flags.This workaround, of course, comes at the cost of making those two lines of code more opaque. Up to the maintainers whether they think that's worth improving this crate's ease of use.
My use case is for a bootloader I'm shipping in source form as part of https://github.com/seL4/rust-sel4. For my use case, requiring downstream users to supply that
-Cargument to rustc viaRUSTFLAGSisn't worth the benefits of using this crate in my bootloader's implementation.