Fix torchax tensor flatten bug on empty tensors#93
Merged
Conversation
wdhongtw
requested changes
May 7, 2026
Collaborator
wdhongtw
left a comment
There was a problem hiding this comment.
LGTM! 👍
Just a few suggestions.
1736f4e to
35e5b9b
Compare
Signed-off-by: Anderson Chiu <andersonchiu@google.com>
wdhongtw
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flatten on tensor of shape contains zero is supported in PyTorch, but not through torchax.
This is due to jax.numpy fails to calculate the correct dimension when input dimension contains 0 and -1 at the same time. It returns a division by zero error.
The new fix avoids sending -1 into jnp.shape by explicitly calculating the flattening dimension to to fix this error: