fix: DSLX C++ transpiler must unique-ify generated temp variable names to not collide with DSLX struct member field names. This applies to struct generators and tuple/array emitters whose temporary variable names were not only colliding with user-generated fields but also the temporary variable names in nested scopes of the generated code for functions like ToValue and FromValue. #3741
+228
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_861393002
branch
from
c13655b to
612b9a8
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_861393002
branch
from
612b9a8 to
377011b
Compare
…s to not collide with DSLX struct member field names. This applies to struct generators and tuple/array emitters whose temporary variable names were not only colliding with user-generated fields but also the temporary variable names in nested scopes of the generated code for functions like ToValue and FromValue. PiperOrigin-RevId: 862334059
copybara-service
bot
force-pushed
the
test_861393002
branch
from
377011b to
932d7d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: DSLX C++ transpiler must unique-ify generated temp variable names to not collide with DSLX struct member field names. This applies to struct generators and tuple/array emitters whose temporary variable names were not only colliding with user-generated fields but also the temporary variable names in nested scopes of the generated code for functions like ToValue and FromValue.