Add OptimizationContext to analysis passes and visitors. #3754
+161
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_861883547
branch
6 times, most recently
from
6520e1d to
0988b2b
Compare
This change modifies several analysis and pass implementations to accept and utilize an OptimizationContext. This allows them to leverage pre-computed topological sorts from the context, avoiding redundant computations. Specifically: - DataflowVisitor and BitProvenanceAnalysis are updated to use `OptimizationContext` for topological sorts. - PredicateDominatorAnalysis is updated to use `OptimizationContext` for reverse topological sorts. - DataflowSimplificationPass and SelectSimplificationPass now pass the `OptimizationContext` to the analyses they use. - Benchmarks for PredicateDominatorAnalysis are updated to test with and without sharing the `OptimizationContext`. PiperOrigin-RevId: 862315781
copybara-service
bot
force-pushed
the
test_861883547
branch
from
0988b2b to
5da1ec3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OptimizationContext to analysis passes and visitors.
This change modifies several analysis and pass implementations to accept and utilize an OptimizationContext. This allows them to leverage pre-computed topological sorts from the context, avoiding redundant computations.
Specifically:
OptimizationContextfor topological sorts.OptimizationContextfor reverse topological sorts.OptimizationContextto the analyses they use.OptimizationContext.