Allow non-trivial final expressions in proc's config function #3756
+51
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dplassgit
requested changes
Jan 28, 2026
| config() { | ||
| const if A == u32:5 { | ||
| let (first_output, first_input) = chan<()>("first"); | ||
| (first_input) |
Contributor
There was a problem hiding this comment.
Probably should be (first_input,) to make it a tuple
| input: chan<()> in; | ||
| output: chan<()> out; | ||
| config() { | ||
| const if A == u32:5 { |
Contributor
There was a problem hiding this comment.
Please add additional tests with a non-const if. Since the parser doesn't require the tuple any more let's make sure the type checker will.
| } | ||
|
|
||
| )", | ||
| TypecheckFails(HasTypeMismatch("(chan<()> in, chan<()> out)", "chan<()> in"))); |
Contributor
There was a problem hiding this comment.
Please add additional tests for channel type mismatch within the const if tuple, e.g., chan<u32> vs chan<()>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug mentioned in #3746 and allows more complex final expressions in proc's config function by skipping the tuple check in
parser.cc.