Update stale v21 API references to v24#61
Merged
Raibaz merged 1 commit intogoogleads:mainfrom Apr 24, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
I have signed the CLA. |
core.py imports from `google.ads.googleads.v21` while the rest of the codebase (utils.py, tests) uses v24. The README API reference link also pointed to v21. Align both to v24.
ZLeventer
force-pushed
the
fix/api-version-v21-to-v24
branch
from
5e58ec9 to
a674232
Compare
Raibaz
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core.pyimport fromgoogle.ads.googleads.v21tov24to match the rest of the codebase (utils.py, test files)Details
utils.py:23and both test files import fromv24, buttools/core.py:22still importsListAccessibleCustomersResponsefromv21. The README link on line 10 also pointed to the v21 reference docs.The
pyproject.tomlrequiresgoogle-ads>=30.1.0, which ships v24.Test plan
nox -s tests)list_accessible_customerstool still works against a live account