Correct misleading scope comment and constant name in utils#64
Merged
Raibaz merged 1 commit intogoogleads:mainfrom Apr 27, 2026
Merged
Correct misleading scope comment and constant name in utils#64Raibaz merged 1 commit intogoogleads:mainfrom
Raibaz merged 1 commit intogoogleads:mainfrom
Conversation
The comment described the Google Ads OAuth scope as belonging to the Analytics Admin and Analytics Data APIs, and called it 'read-only'. The scope (https://www.googleapis.com/auth/adwords) is the Google Ads scope, and Google Ads does not publish a separate read-only variant — read-only behavior comes from the tools this server exposes, not the scope itself. Rename the private constant from _READ_ONLY_ADS_SCOPE to _ADS_SCOPE, update the docstring on _create_credentials accordingly, and replace the comment with an accurate description.
Raibaz
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The comment above the private OAuth scope constant in ads_mcp/utils.py describes it as the scope for the Analytics Admin and Analytics Data APIs, but the value is in fact the Google Ads scope (`https://www.googleapis.com/auth/adwords\`). It also labels the scope read-only — Google Ads does not publish a separate read-only variant; the server is read-only because of the tools it exposes, not the scope.
Changes
No behavior changes — the scope value is unchanged.
Test plan