fix(storage): Remove accept encoding gzip for metadata#33896
Open
shubhangi-google wants to merge 4 commits into
Open
fix(storage): Remove accept encoding gzip for metadata#33896shubhangi-google wants to merge 4 commits into
shubhangi-google wants to merge 4 commits into
Conversation
shubhangi-google
changed the title
shubhangi-google
requested review from
a team and
yoshi-approver
as code owners
shubhangi-google
force-pushed
the
remove_accept_encoding_gzip
branch
from
a523755 to
ca42944
Compare
bajajneha27
changed the title
bajajneha27
changed the title
Contributor
|
LGTM, can we please add some tests? Also is manual testing done for this? |
Contributor
Author
@bajajneha27 Added test to ensure accept encoding header is not added by default |
Contributor
|
Possible to add integration test as well? Also, until you upgrade core library version, this change won't actually work. We need to do that before we can merge this PR. |
bajajneha27
added
the
do not merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modifies the google-cloud-storage library to move the Accept-Encoding: gzip header from a global request.
associated Core library Pr where the header is being added back for media operation: googleapis/google-api-ruby-client#26530