Conversation
product-auto-label
Bot
added
the
api: eventarc
iennae
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when go.mod or go.sum is updated, we do not run tests.
This change folds go.mod and go.sum into the testing process, so that changes to library dependencies lead to running the tests. Most of the test is generating the library, and these dependencies do not impact that. However, the final step of testing library generation is running the tests, and at that point verifying this dependency behavior is important.
In the future, we may split off a dedicated "test the library as-is with updated dependencies" workflow, but for now this is the lowest lift.